Unify to have 1 way of handling scss

[neo]

I notice there are two ways we are handling scss now:

• Injecting sass-loader in to webpack with rewired
• watch scss files to generate css files and import the css file

Each of them has pros and cons but I think we might want to agree to using one and stick to it. 🤔

[iranreyes]

@neo Could you explain your pros and cons here?

[neo]

Sure but my list wouldn't be the complete list:

sass-loader:

• not recommended by create-react-app as it's not generated to work in the future, but we're using rewired anyway... so it might be ok?
• but it would save the actual css files.

watch sass on the side:

• recommended by create-react-app
• could use the global.css in storybook (I'm sure we'll find a way to do it with sass-loader), but now the story book is looking for global.css

These are what I could think of from the top of my head, I'm sure there should be more; please do add more in the comments

[wongbsn]

sass-loader is already in for react-scripts 2: facebook/create-react-app#4195

Might be better to go with that?

[neo]

great! can't wait for the v2

[neo]

I guess it's settled, we just have to wait for version 2 to come out.