Skip to content
This repository has been archived by the owner on Jan 16, 2021. It is now read-only.

Simplify method for adding a page/section to the site. #163

Open
jmckinnell opened this issue Jul 5, 2018 · 1 comment
Open

Simplify method for adding a page/section to the site. #163

jmckinnell opened this issue Jul 5, 2018 · 1 comment
Labels
discussion this is/requires discussion

Comments

@jmckinnell
Copy link
Member

We should try and create a better flow for adding or removing a Page/Section to the site. Currently there are multiple files that need to be modified when creating pages. Something based off the router keys etc might be better.

Relevant files:
https://github.com/Jam3/intern-generator-jam3/blob/master/templates/src/util/async-section-handler.js
https://github.com/Jam3/intern-generator-jam3/blob/master/templates/src/components/Pages/Pages.js
https://github.com/Jam3/intern-generator-jam3/blob/master/templates/src/routes/keys.js

@jmckinnell jmckinnell added the discussion this is/requires discussion label Jul 5, 2018
@namniak
Copy link
Contributor

namniak commented Mar 18, 2019

It's 2 files now since we replacedRreact loadable with React lazy. it may rather complicate code and make it less flexible by moving route components from pages into route keys file esp when nested routes will be introduced. though we've done something like that before. open to discussing it further @iranreyes @jmckinnell

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion this is/requires discussion
Projects
None yet
Development

No branches or pull requests

2 participants