Skip to content
This repository has been archived by the owner on Jan 16, 2021. It is now read-only.

Remove .nvmrc file #205

Open
iranreyes opened this issue Jan 11, 2019 · 4 comments
Open

Remove .nvmrc file #205

iranreyes opened this issue Jan 11, 2019 · 4 comments

Comments

@iranreyes
Copy link
Member

We are already checking in engines within the package.json the right version of npm and node.js. Plus nvm is not smart enough and every time a script runs nvm set the right version and is slowing down every npm script.

@neo
Copy link
Member

neo commented Jan 11, 2019

I believe they serve different purpose, but sure we could use just engine:
engine defines the minimum version the thing needs to run on
while .nvmrc defines the node version you want the thing to run on

@neo
Copy link
Member

neo commented Jan 11, 2019

but additionally for codeship I think it only take .nvmrc, so we could avoid the ugly lines of extracting engine from package.json

@neo
Copy link
Member

neo commented Jan 14, 2019

my bad, codeship actually also takes engines from the package.json file

@craighillwood
Copy link
Contributor

@iranreyes @neo I like having .nvmrc as I have my zsh set with nvm to change/install to the current node version (set in .nvmrc).

Side note: Also, having the engine in package.json helps when the .nvmrc version doesn't fulfill the package.json node version condition 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants