Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool change shortcuts let popovers linger #111

Open
ghost opened this issue Nov 11, 2014 · 0 comments
Open

Tool change shortcuts let popovers linger #111

ghost opened this issue Nov 11, 2014 · 0 comments
Labels

Comments

@ghost
Copy link

ghost commented Nov 11, 2014

Some popover destruction code (e.g., the differential partial definition editor) uses the ChartView's presently selected object to write the changes to. However, changing the active tool clears the selected object (since the type of the object should match the type of the tool, and the easiest way to ensure this is to wipe out the selected object).

When clicking in the Toolbar to change the active tool, this is not an issue; the click sends a destruction message to the popover and changes are written before the selected object is blanked out. When using the keyboard shortcuts to change the active tool, the popover is not sent a destruction message, causing a crash when the popover later tries to close and write data to an unfamiliar selected object.

This is easy to fix: just close all active popovers when receiving a keyboard tool change message.

@ghost ghost added the bug label Nov 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

0 participants