Feature/easynetworkmanager #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- total project refactor and simplification
- getting closer - total refactor of state manager, rest api, and camera handler
- getting closer - total refactor of state manager, rest api, and camera handler, led_manager
lorow
reviewed
Jun 23, 2023
There was a problem hiding this comment.
So, yeah, holy crap. This is HUGE, I love it!
It's a lot of really good work, thank you! It's good to see the things we've been talking about that we wanted to finally tackle and rewrite/fix or outright remove got taken care of, things are looking way better now!
- replace old network stack
|
Looks really good to me. The only thing I'm worried about is the async streaming server as the last time I tried that, it didn't work that great for some users. But we can't know without trying, eh? So, we ready to merge? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the code base and migrates the entire network stack to my custom library
EasyNetworkManager- which was originally inspired by the network stack I made forOpenIris.Along with migrating the network stack notable changes are:
/wifimanagerto set Wifi credentials. Instead of users having to use the REST API.