Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for subtitles #44

Closed
birme opened this issue Apr 8, 2021 · 2 comments · Fixed by #238
Closed

Support for subtitles #44

birme opened this issue Apr 8, 2021 · 2 comments · Fixed by #238
Assignees
@Sgtfishtank
Labels
enhancement New feature or request
Milestone
v4.2.0

Comments

@birme
Copy link
Contributor

birme commented Apr 8, 2021

  • Slice the webvtt media playlist into media sequences aligned with video.
  • Update master manifest response with “virtual” subtitle tracks referenced. Requires to define a predefined set of languages per channel
  • Match available subtitle tracks in VOD with the predefined set of languages per channel. And provide empty / “black” for those tracks without a match
  • Provide a subtitle playlist endpoint that is aligned with the media sequence of video
@birme birme added this to the v3.1.0 milestone Aug 27, 2021
@birme birme removed this from the v3.1.0 milestone May 31, 2022
@birme birme added the enhancement New feature or request label May 31, 2022
@birme
Copy link
Contributor Author

birme commented Sep 23, 2022

Depends on Eyevinn/hls-vodtolive#50

@Ronileco
Copy link

Ronileco commented Feb 8, 2023

Hi @birme - looks awesome!

What about the x-timestamp-map on the vtt file?
Isn't it needed for the subs to work properly during the live stream?

@birme birme added this to the v4.1.0 milestone Feb 27, 2023
@birme birme modified the milestones: v4.1.0, v4.2.0 Mar 14, 2023
@birme birme modified the milestones: v4.2.0, v4.1.0 Apr 12, 2023
@birme birme linked a pull request Apr 12, 2023 that will close this issue
Feat subtitle support #238
Merged
@birme birme modified the milestones: v4.1.0, v4.2.0 Apr 29, 2023
@Sgtfishtank Sgtfishtank mentioned this issue May 5, 2023
Merged
@birme birme closed this as completed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sgtfishtank Sgtfishtank

Labels
enhancement New feature or request
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging a pull request may close this issue.

Feat subtitle support Eyevinn/channel-engine
3 participants
@Ronileco @Sgtfishtank @birme