From e40dca5b14bb42311aa09e2ecb4b5904225a243e Mon Sep 17 00:00:00 2001 From: malmen237 Date: Thu, 11 Apr 2024 10:05:04 +0200 Subject: [PATCH] fix: updated the loader to work on show-refresh-animation instead of loading-boolean --- .../landing-page/productions-list.tsx | 28 +++++-------------- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/src/components/landing-page/productions-list.tsx b/src/components/landing-page/productions-list.tsx index ebdf2f67..318076d4 100644 --- a/src/components/landing-page/productions-list.tsx +++ b/src/components/landing-page/productions-list.tsx @@ -4,6 +4,7 @@ import { API } from "../../api/api.ts"; import { TProduction } from "../production-line/types.ts"; import { useGlobalState } from "../../global-state/context-provider.tsx"; import { LoaderDots } from "../loader/loader.tsx"; +import { useRefreshAnimation } from "./use-refresh-animation.ts"; const ProductionListContainer = styled.div` display: flex; @@ -34,27 +35,17 @@ const ProductionId = styled.div` export const ProductionsList = () => { const [productions, setProductions] = useState([]); - const [loading, setLoading] = useState(true); const [intervalLoad, setIntervalLoad] = useState(false); const [{ reloadProductionList }, dispatch] = useGlobalState(); // TODO extract to separate hook file useEffect(() => { let aborted = false; - let timeout: number | null = null; if (reloadProductionList || intervalLoad) { - setLoading(true); - setIntervalLoad(false); API.listProductions() .then((result) => { - if (aborted) { - if (timeout !== null) { - window.clearTimeout(timeout); - } - return; - } - + if (aborted) return; setProductions( result // pick laste 10 items @@ -79,22 +70,19 @@ export const ProductionsList = () => { dispatch({ type: "PRODUCTION_LIST_FETCHED", }); - timeout = window.setTimeout(() => { - setLoading(false); - }, 2500); + setIntervalLoad(false); }) .catch(() => { // TODO handle error/retry - timeout = window.setTimeout(() => { - setLoading(false); - }, 2500); }); } return () => { aborted = true; }; - }, [dispatch, reloadProductionList, intervalLoad]); + }, [dispatch, intervalLoad, reloadProductionList]); + + const showRefreshing = useRefreshAnimation({ reloadProductionList }); useEffect(() => { const interval = window.setInterval(() => { @@ -108,9 +96,7 @@ export const ProductionsList = () => { return ( <> - {/* // TODO handle so future load-component isn't shown on every update - // TODO ex className={loading && !intervalLoad ? "active" : "in-active"} */} - + {productions.map((p) => (