Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling #125

Open
eliasmalik opened this issue May 12, 2017 · 0 comments
Open

Error handling #125

eliasmalik opened this issue May 12, 2017 · 0 comments

Comments

@eliasmalik
Copy link

Intent of error handling unclear. If you just want to log the error and continue, empty else blocks are confusing.

Also better to write a custom log function for two reasons, first so that you can add extra information to the log message in a structured way, and second so the reader can infer that the logging is intentional and not just left-over from debugging:

https://github.com/FAC10/MPBots/blob/master/src/helper_functions/checkAPIAI.js#L39-L42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant