Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all water settings #10

Open
BlackYps opened this issue Nov 18, 2023 · 5 comments
Open

Expose all water settings #10

BlackYps opened this issue Nov 18, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BlackYps
Copy link

The editor doesn't expose all water settings in the ui. The only way to edit them is by exporting and importing water settings, which is unnecessarily tedious

@BlackYps BlackYps added the good first issue Good for newcomers label Jan 30, 2024
@MrRowey
Copy link
Member

MrRowey commented May 1, 2024

@BlackYps Can you Specify the Water settings?

@BlackYps
Copy link
Author

BlackYps commented May 1, 2024

What do you mean?

@MrRowey
Copy link
Member

MrRowey commented May 1, 2024

What do you mean?

can you give me a refrence to the setting your having to edit then import ?

@BlackYps
Copy link
Author

BlackYps commented May 2, 2024

When you press "export water settings" you will get a file with the complete water settings. Basically these should all be represented in the ui.
There are some exceptions though: sunGlow is not used by the shader, so you can omit that. Same for sunStrength, sunReflection, fresnelPower and fresnelBias.

@BlackYps
Copy link
Author

BlackYps commented May 2, 2024

The two values of colorLerp should be represented as two independent values surface color lerp min and surface color lerp max as this is how they are used in the shader.

@BlackYps BlackYps added the enhancement New feature or request label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants