Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Warn players when XACT-errors are in their logs #3142

Open
Basilisk3 opened this issue Mar 5, 2024 · 4 comments · May be fixed by #3290
Open

Feature request: Warn players when XACT-errors are in their logs #3142

Basilisk3 opened this issue Mar 5, 2024 · 4 comments · May be fixed by #3290

Comments

@Basilisk3
Copy link

Issues with surround sound are one of the most common causes for crashes. It would be nice if the client could scan for those in the logs, and then warn the player to disable surround sound.

Credits go to @4z0t for this idea.
@Basilisk3 Basilisk3 changed the title Feature request: Warn players when XACT are in their logs Feature request: Warn players when XACT-errors are in their logs Mar 10, 2024
@Ivan-Shaml
Copy link

What do you think about this implementation:

image

@Ivan-Shaml Ivan-Shaml linked a pull request Dec 30, 2024 that will close this issue
Open
@Ivan-Shaml
Copy link

Update:
After more careful analysis I was not able to copy the link while trying to select it with the mouse, so I moved it to an action button.
Update UI:
image

@Ivan-Shaml
Copy link

Ivan-Shaml commented Dec 31, 2024 •
edited
Loading

New version:
Show only on game crash (exitCode != 0). Show possible solutions button only present, if issue was detected in the log.
image

@Basilisk3
Copy link
Author

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: warn players when XACT-errors are in their logs Ivan-Shaml/downlords-faf-client-fork
2 participants
@Ivan-Shaml @Basilisk3