Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms of Service check on login #199

Open
Brutus5000 opened this issue Dec 3, 2023 · 2 comments · May be fixed by #368
Open

Terms of Service check on login #199

Brutus5000 opened this issue Dec 3, 2023 · 2 comments · May be fixed by #368
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Brutus5000
Copy link
Member

db v132 added new columns and tables to represent the FAForever terms of service.

The next step is to check on each login, if a member already accepted the latest ToS.

If the ToS in the user data is not the latest, right after entering username/password the user must be shown a screen with the latest ToS and button to accept. If the ToS is accepted, store this information in the login data of that user and proceed with the OAuth consent screen.

@Brutus5000 Brutus5000 added enhancement New feature or request good first issue Good for newcomers labels Dec 3, 2023
@Ivan-Shaml
Copy link

Hi, I have several questions

Current state UI:
image

  1. What should be the title of the dialog in English, I will add i18n for it
  2. Is the style for the Accept/Decline buttons ok, is the text of the buttons ok (i18n will be added if not exists)
    2.1. (UX question) Should there be a decline button at all ?
  3. Currently if user clicks Decline, nothing happens, just the dialog gets closed, what should be the behavior ?

@Ivan-Shaml Ivan-Shaml linked a pull request Dec 28, 2024 that will close this issue
Ivan-Shaml added a commit to Ivan-Shaml/faf-user-service-fork that referenced this issue Dec 29, 2024
@Brutus5000
Copy link
Member Author

  1. Please accept our latest terms of services
  2. Looks fine to me.
  3. I would do the same things we do when the user declines the consent screen. Cancel the login flow in the hydra service. On top of that I would show a non-closable dialog (e.g. registration view) that login is not possible as long as the ToS are not accepted. Later on we might need to add a link on how to delete the account.

Also that kind of brings me to the point that the account deletion process must work outside the login flow, otherwise you cannot delete your account without accepting the ToS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants