Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matchmaker rating shown as 0 #868

Open
BlackYps opened this issue Dec 19, 2021 · 8 comments
Open

Matchmaker rating shown as 0 #868

BlackYps opened this issue Dec 19, 2021 · 8 comments

Comments

@BlackYps
Copy link
Collaborator

The client shows no 4v4 matchmaker rating for many people when they play their first game even though the initialization happens correctly on the server. So it defaults to 0 in game.
Oddly enough for some people it works.
Correct rating initialization can be confirmed by looking at the ratings of the replay after the game has finished

@Sheikah45
Copy link
Member

This happens because the server does the initialization internally and doesn't send the client the players rating before the game starts so the client defaults to zero.

So this isn't really a client issue because it doesn't have the necessary information

@BlackYps
Copy link
Collaborator Author

Then why does it work for some players?

@Sheikah45
Copy link
Member

Largely this is probably just a race condition which is why it works for some people

@BlackYps
Copy link
Collaborator Author

Also, @Askaholic says they are in the player_info message, so the client can get them from there. I suspect that is why it works for some people, depending on when the message arrives

@Sheikah45
Copy link
Member

The player_info message is not sent out right as soon as a change occurs. The server batches up the players and sends then in intervals. So that is the race condition. If it gets an updated message before the game starts it will show the initialized rating. If it doesn't then the players will show as 0.

@Askaholic
Copy link
Collaborator

Makes sense. Probably the right thing to do would be to add the rating to the game_launch message?

@Sheikah45
Copy link
Member

for who all the players just the player who the message is going to? Also I will move this to the server

@Sheikah45 Sheikah45 transferred this issue from FAForever/downlords-faf-client Dec 19, 2021
@BlackYps
Copy link
Collaborator Author

BlackYps commented May 7, 2024

This could be made irrelevant with FAForever/fa#6160 because then the bug doesn't show up anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do
Development

No branches or pull requests

3 participants