Report form autocomplete = broken

[Viba]

Users are unable to report other users due to the autocomplete not autocompleting properly.

e.g. trying to report "Kalvirox" it returns results for the first two and three letters like below (with weird spaces), then nothing. If the form doesn't find a valid player it doesn't allow filing a report. This is quite important to moderation.

[Brutus5000]

It works but it is broken by design.

I looked up the code and it seems to work like this:
It only collects player names of the players who played a game in the last 24 hours at the moment of startup and never refreshes it.

[1-alex98]

I will just check if I am reportabe and if not I can do what I want XD @Brutus5000 when is the next restart?

[Brutus5000]

Looks like it crashed 11 minutes ago and was restarted

[1-alex98]

Well it updates the names every 15 minutes

[Rackover]

You can submit a report even if the autocomplete does not include it now, so is that still a problem?
The suggestions when writing someone's name are incomplete because they only include players from the last 24 hours for performance/caching reasons, but this could be changed and/or extended if necessary - ultimately as long as we rely on caching it will result in passing a huge list of names to the client/browser and making the page more heavy (or we could kill caching and fetch the names from the API as they are typed, realtime, but not sure how to do that with awesomplete)

[Brutus5000]

Are we sure it is refreshed once per day? I think I didn't find anything related back then.

[Rackover]

Every 15 minutes normally! https://github.com/FAForever/website/blob/develop/express.js#L293
Script is there : https://github.com/FAForever/website/blob/develop/scripts/getRecentUsers.js

Now only way to see if it actually runs on prod is to check website logs on prod. Locally it appears to work, but test server has no recent games so no players get updated on it! Also 15 minutes might be a bit long...

[Brutus5000]

Would be good to log these jobs not only when the fail :)

[Rackover]

Would be good to log these jobs not only when the fail :)

there is logging in the normal behaviour look :

    console.log(moment().format("DD-MM-YYYY - HH:mm:ss")  + ' - Updating the recent users...'); // When it starts
    console.log(moment().format("DD-MM-YYYY - HH:mm:ss") + ' - Recent players file created successfully'); // When it finishes

Could you look at prod logs and see if they're here?

[Brutus5000]

It does work now. I'm pretty sure the log was mostly empty back then 🤷

[Rackover]

So is that... still an issue ? 😄

[fcaps]

Still an issue😄
new design/layout, but autocomplete is still broken

[fcaps]

finally fixed with #504