Add support for postgresql database (for FDP develop) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add comments - remove -r flag (recursive not needed when copying file) - verbose option --in-place for clarity
- add comments - rename fdp-server service to fdp (for consistency) - add postgresql db service - use docker compose profiles to enable selection of db service mongo/postgres
consistent with modern compose.yml default filename
remove unnecessary sed backup files
the based image name remains the same anyway
and clean up references
dennisvang
changed the title
and restrict container access to localhost https://docs.docker.com/engine/network/#published-ports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FDP
developbranch uses postgres, whereas current releases 1.16 and 1.17 use mongodb.This PR adapts the docker compose configuration to support both mongodb and postgres.
The correct database config is automatically selected by
init.sh, based on the specified FDP image.In addition, docker-related commands and filenames have been modernized.
*_IMAGEenv variables by*_VERSION, for convenienceinit.shto select either mongo or postgres, based on FDP imagenpm run testfor convenienceMakefileto use modern docker compose callsREADMEto reflect the changesOPEN_REFINE_IMAGEenv variable reference from readme (as it does not appear to be used)fixes #13