Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to select multiple records to approve #2321

Open
delphinedauga opened this issue May 12, 2024 · 3 comments
Open

Possibility to select multiple records to approve #2321

delphinedauga opened this issue May 12, 2024 · 3 comments
Labels
enhancement New feature or request low Priority for this task is low

Comments

@delphinedauga
Copy link
Contributor

delphinedauga commented May 12, 2024

Approving a record in the curation dashboard often takes a few minutes (sometimes it's a second, sometimes, it's one ore two minute). Therefore, when we have to approve a dozen or so records (which happens frequently), it can take a long time. @allysonlister and I have observed the same behavior.
Would it be possible to select several records that can be approved in one go? Or would it be possible to look at why approving a record takes so long and whether it can be optimised?
Thanks !

@delphinedauga delphinedauga added enhancement New feature or request low Priority for this task is low labels May 12, 2024
@knirirr
Copy link
Contributor

knirirr commented May 15, 2024

Have you noticed this problem with any particular registry or type of record?
I ought to look into the speed first and so will be looking to try to reproduce it.
If I can't I might need to ask one of you to share your screen with the developer tools open.

@allysonlister
Copy link
Contributor

I'll check the timings, probably tomorrow when I do some curation, and get back to you. Happy to do a developer tools session if required, would be happy to just have a solution to the underlying problem, indeed.

@knirirr
Copy link
Contributor

knirirr commented May 16, 2024

I've had a quick look at this myself and can't reproduce any delays; everything is quick on each approval.
All that happens is a PUT in which data like these are sent:

{"fairsharing_record":{"approved":true,"skip_approval":true,"processing_notes":null,"create_review":true,"hidden":true}}

So, I think I'm definitely going to need to see it in action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low Priority for this task is low
Projects
Status: Awaiting response
Development

No branches or pull requests

3 participants