Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting code to API ROR v2 #2434

Open
ramGranell opened this issue Nov 26, 2024 · 2 comments
Open

Adapting code to API ROR v2 #2434

ramGranell opened this issue Nov 26, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ramGranell
Copy link
Contributor

A new version for ROR is used (v2) and our code needs to be adapted as we are currently using V1. This is related to this ticket
https://github.com/FAIRsharing/FAIRsharing-API/issues/783

@ramGranell ramGranell added the enhancement New feature or request label Nov 26, 2024
@ramGranell ramGranell self-assigned this Nov 26, 2024
@ramGranell
Copy link
Contributor Author

@allysonlister In ROR v2 they are using the following types for organisations (https://ror.readme.io/v2/docs/fields) :+archive, company, education, facility, funder, government, healthcare, nonprofit, other
I currently do the following mapping between their organisation type and our types (Government body, Charitable foundation, University, Research Institute, Lab, Company, Consortium, Published, Undefined):
ROR_type -> FAIRsharing_type
archive -> Undefined
company -> Company
education -> University
facility -> Undefined
funder -> Undefined
government -> Government body
healthcare -> Undefined
nonprofit -> Charitable foundation
other -> Undefined

Do you think, do we need another matching? You need to remember that this is later possible to be changed by the user creating the organisation.

@allysonlister
Copy link
Contributor

I don't think we can safely modify any of our existing mappings to undefined, so I suggest we leave it as it is. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants