Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gdim input to UFL elements, move value_shape to function space #2996

Merged
merged 49 commits into from
Feb 10, 2024
Merged

Remove gdim input to UFL elements, move value_shape to function space #2996

merged 49 commits into from
Feb 10, 2024

Conversation

mscroggs
Copy link
Member

@mscroggs mscroggs commented Jan 18, 2024 •
edited
Loading

@mscroggs mscroggs marked this pull request as draft January 18, 2024 09:44
@mscroggs mscroggs marked this pull request as ready for review January 22, 2024 18:25
@mscroggs mscroggs marked this pull request as draft January 26, 2024 18:02
@mscroggs mscroggs marked this pull request as ready for review January 29, 2024 14:32
@garth-wells
Copy link
Member

Looking at the direction of travel in this PR, could we remove block size from FiniteElement and move it to the FunctionSpace?

I think that would make sense

I guess mixed elements are problematic. Maybe info on mixed elements should be held by the FunctionSpace too?

@mscroggs
Copy link
Member Author

Looking at the direction of travel in this PR, could we remove block size from FiniteElement and move it to the FunctionSpace?

I think that would make sense

I guess mixed elements are problematic. Maybe info on mixed elements should be held by the FunctionSpace too?

Yes, was just thinking about this. I think we consider this PR now, then work on this afterwards. I think there a fair amount of refactoring in FFCx and possibly UFL to make this change.

This was referenced Jan 29, 2024
Merged
Merged
Merged
@mscroggs mscroggs changed the title Remove gdim input to UFL elements Remove gdim input to UFL elements, move value_shape and value_size from element to function space Jan 29, 2024
@mscroggs mscroggs changed the title Remove gdim input to UFL elements, move value_shape and value_size from element to function space Remove gdim input to UFL elements, move value_shape to function space Jan 29, 2024
@mscroggs mscroggs enabled auto-merge February 10, 2024 11:30
@mscroggs mscroggs added this pull request to the merge queue Feb 10, 2024
Merged via the queue into main with commit ac30bd4 Feb 10, 2024
19 checks passed
@mscroggs mscroggs deleted the mscroggs/gdim branch February 10, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrichardson chrisrichardson chrisrichardson left review comments

@jorgensd jorgensd jorgensd left review comments

@garth-wells garth-wells garth-wells approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mscroggs @garth-wells @chrisrichardson @jorgensd