Write and read mesh using ADIOS2 #3291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update cmakelists
Debug local-to-global mapping
jorgensd
reviewed
Jul 10, 2024
jorgensd
reviewed
Jul 10, 2024
|
What's going on with this one @ampdes? Is it ready to review? |
|
A preliminary review of the structure/naming in the slack channel will be appropriate first. |
jorgensd
reviewed
Aug 6, 2024
cpp/dolfinx/io/checkpointing.cpp
Outdated
Comment on lines
82
to
83
| const std::vector<int64_t> input_global_indices | ||
| = geometry.input_global_indices(); |
There was a problem hiding this comment.
Suggested change
| const std::vector<int64_t> input_global_indices | |
| = geometry.input_global_indices(); | |
| const std::vector<int64_t>& input_global_indices | |
| = geometry.input_global_indices(); |
This could be const right?
jorgensd
reviewed
Aug 6, 2024
jorgensd
reviewed
Aug 6, 2024
* Update copyright headers * Remove ADIOS_utils.cpp * Correct the global topology computation * Rename vertices to nodes
Add Append adios mode Add complete set of basix enum-string maps
ampdes
added a commit
to ampdes/dolfinx
that referenced
this pull request
Aug 18, 2024
jorgensd
reviewed
Aug 30, 2024
cpp/demo/checkpointing/main.cpp
Outdated
Comment on lines
44
to
47
| for (std::size_t i = 0; i < x.size(); ++i) | ||
| { | ||
| x[i] *= 4; | ||
| } |
There was a problem hiding this comment.
We could use std::for_each to illustrate good coding practices, see:
https://godbolt.org/z/97osavhb6
Co-authored-by: Jørgen Schartum Dokken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces module for native checkpointing using ADIOS2.
For the python APIs, we cannot use the ADIOS2 python bindings which are based on pybinds, hence a wrapper to ADIOS2 is created.
The ADIOS2 BeginStep() and EndStep() collectives are designed per write function. However, for the reader, we have that the BeginStep is external to function to first query the types and then call the reader with the correct type.
This PR has mesh writer/reader.
For time dependent mesh, the topology is written once and and only geometry is written with time dependency.
Therefore for reading, we have two separate functions
read_meshwhich reads the topology and geometry and constructs a mesh and thenupdate_meshwhich takes this mesh and updates the associated geometry at a later time.TODO: