-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TimeLogManager
and make TimeLogger
singleton
#3494
base: main
Are you sure you want to change the base?
Conversation
What's the advantage of a monostate design over a singleton? Looks to me to all intents and purposes to be the same thing. |
I think in this case it results in the same. We can decide on the interface we prefer, rather calling some kind of an |
Shall we stick to the monostate or return to the singleton approach, just within |
After reading the comments I would recommend singleton - as @garth-wells says there is little clear advantage, and singleton is at least well-known (and people understand the issues). |
TimeLogManager
and make TimeLogger
monostateTimeLogManager
and make TimeLogger
singleton
Fixes #3480