Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop image deployment if specified disk not found #100

Open
Peter-Csatlos opened this issue Jan 2, 2025 · 2 comments
Open

Stop image deployment if specified disk not found #100

Peter-Csatlos opened this issue Jan 2, 2025 · 2 comments

Comments

@Peter-Csatlos
Copy link

Is your feature request related to a problem? Please describe.
Some of the machines I use FOG with have multiple disks. For these machines, I have set the "Host Primary Disk" by the unique id of the SSD. After imaging around 100 machines last week, I noticed that on one machine the new image went to it's HDD. It probably had an SSD failure some time last year, so it was changed without updating the field in FOG. Now the Primary Disk setup does nothing. In this case, the actual data loss is not an issue, but I can see that this could be a major problem for someone.

Describe the solution you'd like
I would like to the image deployment process to fail if the Host Primary Disk field is set but the specified disk is not found. This should be an optional feature, so the current behavior is kept if this is toggled off.
The best implementation would be if the task would go in a "failed" state, so the admins can see on the web ui that there is an issue and the machine is not just silently in a boot loop. This failed state would remain until and admin is removing the task and the failed task should not be picked up again by the machine so it can boot back into the installed OS.

@mastacontrola mastacontrola transferred this issue from FOGProject/fogproject Jan 14, 2025
@mastacontrola
Copy link
Member

I have transferred this where this should actually sit. That said, I think I understand what you're asking.

Effectively:

"If the host primary disk is set and the device doesn't have said host primary disk, don't try to image."

Is this correct? I know it's probably obvious but just want to make sure the language is simplified and clear.

@Peter-Csatlos
Copy link
Author

Thank you, this is exactly what I meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants