Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Plugin "is restricted user" is missing in 1.6 #674

Open
tailz303 opened this issue Jan 7, 2025 · 4 comments
Open

Site Plugin "is restricted user" is missing in 1.6 #674

tailz303 opened this issue Jan 7, 2025 · 4 comments

Comments

@tailz303
Copy link

tailz303 commented Jan 7, 2025

Describe the bug
Tested on both 1.5.10 and 1.6, when trying to make the user restricted to only see the hosts in their site, it is not possible as the menu item for restricting the user is not showing up.

To Reproduce
Steps to reproduce the behavior:

  1. Go to users
  2. select user
  3. site association plugin
  4. under the general tab there should be an "is restricted user" checkbox which is visible in 1.5.10 but not 1.6

Expected behavior
In order for the sites plugin to be useful, there needs to be a way to restrict users to only be able to access the hosts in their site but it seems like the option to do this is not present.

Screenshots
Correct format of 1.5
image(2)

Broken format of 1.6
image

Software (please complete the following information):

  • FOG version [e.g. 1.6-beta]
  • FOS kernel [e.g. 6.6.49]
  • OS: [e.g. Ubuntu 22.04]
@darksidemilk
Copy link
Member

darksidemilk commented Jan 7, 2025

Screenshot_20250107_162849_Edge.jpg

It's under the plug-ins site associations tab.
You can also set the user associations from the site

@tailz303
Copy link
Author

tailz303 commented Jan 8, 2025

The issue I'm facing is that adding a user to a site that has a specific amount of hosts has no way to limit that user to only seeing those hosts. here is a collage of images to hopefully help demonstrate the issue.
Screenshot_20250107-172542~2
Screenshot_20250107-172600~2
Screenshot_20250107-172627~2
Screenshot_20250107-172727~2

let me know if I am still missing something and sorry for the crappy pictures I am not at my desk currently.

@darksidemilk
Copy link
Member

I have never actually used the access control plugin or the sites plugin in my production servers.
Did it previously filter automatically?
I know that the list view of hosts is done differently and the sites plugin might need some tlc to adapt the filtering of the view. It is a plugin though, not a core functionality, so it was built by a community member I believe.

@tailz303
Copy link
Author

tailz303 commented Jan 8, 2025

Hi @darksidemilk Sorry for the delayed reply. I hadn't actually tested this on 1.5.10 before now as we were just going off of the docs for the plugin but it does appear that checking "Is restricted user" and associating that user to a site and selecting a host for that site only allows the user to see that host. So the seemingly broken functionality is the missing "is restricted user" in 1.6. I can provide screenshots but just imagine that the full list of hosts goes down to the list of hosts in the site once the user is added to the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants