Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root named "-root- -cellular organism" #34

Open
CarolineOhrman opened this issue Jun 30, 2023 · 2 comments
Open

root named "-root- -cellular organism" #34

CarolineOhrman opened this issue Jun 30, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@CarolineOhrman
Copy link
Contributor

I made a tree and got a root named "cellular organism"

ran
CanSNPer2 --database bacillus_anthracis_new.db data/*.fasta --summary --save_tree --tmpdir temp/ --strictness 0.8
and got a warning about that cellular organism has no snp_annotation:

2023-06-30 13:13:29,429 NewickTree [WARNI] #Node has no snp_annotation root
2023-06-30 13:13:29,429 NewickTree [WARNI] #Node has no snp_annotation cellular organisms
2023-06-30 13:13:29,429 NewickTree [WARNI] #Node has no snp_annotation A.Br.011

and also a node in the tree pdf named "-root- -cellular organism":

Vollum_GCF_022221345.1_ASM2222134v1_tree.pdf

@CarolineOhrman CarolineOhrman changed the title root named root named "-root- -cellular organism": Jun 30, 2023
@CarolineOhrman CarolineOhrman changed the title root named "-root- -cellular organism": root named "-root- -cellular organism" Jun 30, 2023
@druvus
Copy link
Contributor

druvus commented Jul 15, 2023

@davidsundell Do you have a suggestion how to fix it?

@davve2 davve2 self-assigned this Jul 16, 2023
@davve2 davve2 added the bug Something isn't working label Jul 16, 2023
@davve2
Copy link
Contributor

davve2 commented Jul 16, 2023

Problem

FlexTaxD ReadTaxonomyCanSNPer module creates root and cellular_organism node by default.

Solution

Move the creation of these nodes from init to the "parse_taxonomy function" (in FlexTaxD), this function is overrides in CanSNPer2 and can skip this step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants