Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error on nginx > 1.10 #57

Open
c0de9en opened this issue Jul 5, 2017 · 4 comments · May be fixed by #64
Open

Compilation error on nginx > 1.10 #57

c0de9en opened this issue Jul 5, 2017 · 4 comments · May be fixed by #64

Comments

@c0de9en
Copy link

c0de9en commented Jul 5, 2017

make[1]: Entering directory '/usr/local/src/nginx-1.13.2'
cc -c -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I /usr/include/postgresql -I objs -I src/http -I src/http/modules -I ../njs/nginx/../nxt -I ../njs/nginx/../njs -I src/stream -I ../njs/nginx/../nxt -I ../njs/nginx/../njs
-o objs/addon/src/ngx_postgres_module.o
../ngx_postgres/src/ngx_postgres_module.c
../ngx_postgres/src/ngx_postgres_module.c: In function ‘ngx_postgres_find_upstream’:
../ngx_postgres/src/ngx_postgres_module.c:1323:21: error: ‘ngx_http_upstream_srv_conf_t {aka struct ngx_http_upstream_srv_conf_s}’ has no member named ‘default_port’
if (uscfp[i]->default_port && url->default_port
^
../ngx_postgres/src/ngx_postgres_module.c:1324:25: error: ‘ngx_http_upstream_srv_conf_t {aka struct ngx_http_upstream_srv_conf_s}’ has no member named ‘default_port’
&& (uscfp[i]->default_port != url->default_port))
^
objs/Makefile:1454: recipe for target 'objs/addon/src/ngx_postgres_module.o' failed

@agentzh
Copy link
Contributor

agentzh commented Jul 5, 2017

@an0ma1ia See the patch in #52.

@c0de9en
Copy link
Author

c0de9en commented Jul 5, 2017

Thank you.
I commented out that IF and compiled nginx. Is it possible to apply the patch to the official sources?

@agentzh
Copy link
Contributor

agentzh commented Jul 5, 2017

@an0ma1ia Yes, when this module is officially tested against newer versions of nginx. Before that, you are at your own risk if you haven't run the test suite in all those test modes yourself :)

See https://qa.openresty.org/

@pbkh-kimheang
Copy link

I have the same problem. I am new to NGINX. Could you help please?

lindt added a commit to lindt/ngx_postgres that referenced this issue Sep 3, 2020
current versions of nginx do not provide the default port anymore. So the code will not compile with current versions.
@Bibop182 Bibop182 linked a pull request Sep 29, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants