Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working around custom attributes #7

Closed
ozodrukh opened this issue May 23, 2016 · 5 comments
Closed

Working around custom attributes #7

ozodrukh opened this issue May 23, 2016 · 5 comments

Comments

@ozodrukh
Copy link

I tried to invent this project weeks ago, but i gave up because of custom attributes support, as you started i wish i could help you in development if i find time.

Anyway we could not support custom attributes.
What can we do? Give an interface to call custom methods in order to setup and notify user that we don't support them overtime he mades changes in the layout

@FabianTerhorst
Copy link
Owner

@Alexander--
Copy link

Alexander-- commented May 23, 2016

I tried to invent this project weeks ago, but i gave up because of custom attributes support, as you started i wish i could help you in development if i find time.

Same here. I have been continuously coming with all kinds of workarounds, but gave up after realising, that…

  • Themes won't ever fully work because of the way attributes are processed;
  • Even if you get them to work, someone would have to write mountains of boilerplate mappings for custom attributes.

All of that solely to combat AssetManager.

Nevertheless, good luck with this project.

…for custom attributes i had the idea to add converters with annotations… But the reflection to init the converter class doesn´t work right now.

@FabianTerhorst Have you considered using ServiceLoader?

Forget that, I have just recalled seeing less roundabout solution in other library. I will elaborate in #10.

@FabianTerhorst
Copy link
Owner

@Alexander-- have you also tried to create a XmlBlock.Parser with reflection?

@FabianTerhorst
Copy link
Owner

@Alexander-- but im sure setting a theme programatically should work. I will try to find a solution for this.

@FabianTerhorst
Copy link
Owner

@Alexander-- themes should working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants