Custom Block Entity With A GUI Blinks

[Gamer069]

i wanted to make a diamond crafting table block entity with a gui, but for some reason, when i open this gui, it opens with an expected gui, then it closes, i have a repository for this

[warjort]

Check your run/logs/latest.log there is likely an error in there.

e.g. First thing I find is this is never registered.
https://github.com/Gamer069/illia_fabric_1_19_mod/blob/24b2d32f3e3a51c54d25119f15d79740f593568b/src/main/java/net/illia/illiafabricmod1_19/screen/ModScreenHandlers.java#L9

[Gamer069]

but how do i fix the blinking?

[warjort]

You haven't updated your repository with the latest changes.
Or if you have, you haven't fixed the registration problem.

[Gamer069]

thanks, but how do i register it properly?

Registry.register(Registry.SCREEN_HANDLER, new Identifier(IlliaFabricMod1_19.MOD_ID, "diamond_crafting_table_screen_handler"), DIAMOND_CRAFTING_TABLE_SCREEN_HANDLER);

like this?

[Gamer069]

or is this just for the

ScreenHandlerType.register();

to function properly?

[warjort]

Looks ok to me.

[warjort]

Your next problem is here:
https://github.com/Gamer069/illia_fabric_1_19_mod/blob/1d1864562ece267a6bbf5f35f2f9c0d9cfd1cdd6/src/main/java/net/illia/illiafabricmod1_19/block/custom/DiamondCraftingTable.java#L77

You are telling it to display the vanilla crafting table screen.
This will check your block is a vanilla crafting table and close the screen if it is not.
See CraftingScreenHandler.canUse()

You want it to use your ScreenHandler
You are using a BlockEntity - the vanilla crafting table is not a block entity so the code is different.

You want something like the following in DiamondCraftingTable (untested code):

	@Override
	public ActionResult onUse(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockHitResult hit) {
		if (!world.isClient) {
	            BlockEntity blockEntity = world.getBlockEntity(pos);
	            if (blockEntity instanceof DiamondCraftingTableBlockEntity diamondCraftingTableBlockEntity) {
	                player.openHandledScreen(diamondCraftingTableBlockEntity);
	            }
		}
		return ActionResult.SUCCESS;
	}

You don't need that createScreenHandlerFactory() method in that class. Your BlockEntity is a NamedScreenHandlerFactory
https://github.com/Gamer069/illia_fabric_1_19_mod/blob/1d1864562ece267a6bbf5f35f2f9c0d9cfd1cdd6/src/main/java/net/illia/illiafabricmod1_19/block/entity/DiamondCraftingTableBlockEntity.java#L24

[Gamer069]

thanks, i will look at vanilla screen handlers now

[Gamer069]

thanks, it worked now

[Gamer069]

also, how do i make my recipe type work?

[warjort]

Can you start a new discussion topic.
This one is already answered and it is way too long.

[Gamer069]

ok, i made it here