Registry sync calls getLootTableId on every registered block for seemingly no reason

[Technici4n]

See the following:

fabric/fabric-registry-sync-v0/src/main/java/net/fabricmc/fabric/impl/registry/sync/trackers/vanilla/BlockInitTracker.java

Line 48 in 65c120e

object.getLootTableId();

No idea why this exists and what that actually does.

Found while working on the NeoForge registry rework, NeoForge also has this but it's unclear why so it will be removed...

[Juuxel]

It might be something vanilla does/did? From an ancient version of reg sync:

fabric/fabric-registry-sync-v0/src/main/java/net/fabricmc/fabric/impl/registry/vanilla/BootstrapBlockRegistryListener.java

Lines 41 to 45 in eff4f58

	@Override
	public void afterRegistryRegistration(Registry<Block> registry, int id, Identifier identifier, Block object) {
	// refer net.minecraft.block.Blocks
	object.getDropTableId();
	}

[modmuss50]

This is done as it matches Vanilla in Blocks.<clinit>. I expect at somepoint previously it mattered more.

I think removing this could be breaking as lootTableId is only protected in Block, and a mod may not expect it to be null. I think it should be left alone.

[Technici4n]

Yes you are right, I didn't see that Blocks.<clinit> call... 🙃