Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Villagers and players appear rotated in beds when Fabric API is installed #3470

Closed
joshuaprince opened this issue Dec 16, 2023 · 2 comments
Closed
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.

Comments

@joshuaprince
Copy link

The sleeping pose incorrectly renders entities' rotation, causing them to show up incorrectly in beds. This happens with Fabric API and no other mods installed. Removing Fabric API fixes the issue.

MC 1.20.4, Fabric 0.15.2, FAPI 0.91.2+1.20.4:
2023-12-15_21 50 31
2023-12-15_21 59 46

MC 1.20.4, Fabric 0.15.2, no other mods:
2023-12-15_21 50 58
2023-12-15_22 00 22

Extra information:
MC 1.20.4
Fabric 0.15.2
Fabric API 0.91.2+1.20.4
OS: Arch Linux
Java: openjdk 17.0.9 (same happens on 21)

@dicedpixels
Copy link

dicedpixels commented Dec 16, 2023

Can confirm.

2023-12-16_11 48 06

The hitbox:

2023-12-16_11 55 41

latest.log


Edit:

Based on some quick testing based on GH Actions builds, it appears to be this 78d798a

And likely this mixin:

private void onGetSleepingDirection(CallbackInfoReturnable<Direction> info, @Local @Nullable BlockPos sleepingPos) {

(Probably the locals 🥲)

@apple502j apple502j added bug Something isn't working priority:medium Medium priority PRs that should get reviews labels Dec 16, 2023
@apple502j
Copy link
Contributor

Ah yes, getReturnValue before return. What could go wrong?

@apple502j apple502j added priority:high High priority PRs that need review and work now. Review these first. and removed priority:medium Medium priority PRs that should get reviews labels Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants