Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.20.5 Resource Loader messes with Builtin Resourcepacks in Resourcepacks Screen #3729

Closed
FirstMegaGame4 opened this issue Apr 23, 2024 · 1 comment · Fixed by #3730
Closed

1.20.5 Resource Loader messes with Builtin Resourcepacks in Resourcepacks Screen #3729

FirstMegaGame4 opened this issue Apr 23, 2024 · 1 comment · Fixed by #3730
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.

Comments

@FirstMegaGame4
Copy link

FirstMegaGame4 commented Apr 23, 2024 •
edited
Loading

Noticed it while updating my Environment Driven Assets mod, since it uses a Builtin Resourcepack.

Video Issue: https://streamable.com/c06ngn.

Small Reproduction Case: https://github.com/FirstMegaGame4/1.20.5-resourceloader-builtin-resourcepacks-issue.

Minecraft 1.20.5
Fabric API 0.97.5+1.20.5
@modmuss50 modmuss50 added bug Something isn't working priority:high High priority PRs that need review and work now. Review these first. labels Apr 23, 2024
@FirstMegaGame4
Copy link
Author

After some investigation, it's only an issue with the screen itself, the pack works.

@FirstMegaGame4 FirstMegaGame4 changed the title 1.20.5 Resource Loader messes with Builtin Resourcepacks 1.20.5 Resource Loader messes with Builtin Resourcepacks in Resourcepacks Screen Apr 23, 2024
@modmuss50 modmuss50 mentioned this issue Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement BuiltinModResourcePackSource.equals/hashCode modmuss50/fabric
2 participants
@modmuss50 @FirstMegaGame4