Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when loading void superflat with registered biome modifications #3736

Closed
Oliver-makes-code opened this issue Apr 26, 2024 · 4 comments · Fixed by #3741
Closed

Crash when loading void superflat with registered biome modifications #3736

Oliver-makes-code opened this issue Apr 26, 2024 · 4 comments · Fixed by #3741
Assignees
@apple502j
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.

Comments

@Oliver-makes-code
Copy link

Oliver-makes-code commented Apr 26, 2024 •
edited
Loading

Crash log: https://mclo.gs/lH6dDg6

Minimal reproduction repository: https://github.com/Oliver-makes-code/biome-modification-crash

Reproduction steps:

  1. Run the client with the reproduction repository
  2. Create a new void superflat world
  3. Crash
@Oliver-makes-code
Copy link
Author

I'm investigating this issue further

@Oliver-makes-code Oliver-makes-code changed the title Crash when loading superflat with registered biome modifications Crash when loading void superflat with registered biome modifications Apr 26, 2024
@Oliver-makes-code
Copy link
Author

It appears I had the reproduction wrong, I amended that.

@Oliver-makes-code
Copy link
Author

Oliver-makes-code commented Apr 27, 2024 •
edited
Loading

fabric/fabric-biome-api-v1/src/main/java/net/fabricmc/fabric/impl/biome/modification/BiomeModificationImpl.java

Line 160 in a704f5c

dimensionOptions.chunkGenerator().indexedFeaturesListSupplier = Suppliers.memoize(

This could be where the issue is originating

@apple502j apple502j self-assigned this Apr 27, 2024
@apple502j apple502j added bug Something isn't working priority:high High priority PRs that need review and work now. Review these first. labels Apr 28, 2024
@apple502j
Copy link
Contributor

Pro tip: always test superflat worlds, even if you're testing Biome API...

@apple502j apple502j mentioned this issue Apr 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apple502j apple502j

Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash when generating flat world apple502j/fabric
2 participants
@apple502j @Oliver-makes-code