Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic registry loading location ignores namespace #4179

Closed
Gaming32 opened this issue Oct 22, 2024 · 2 comments · Fixed by #4180
Closed

Dynamic registry loading location ignores namespace #4179

Gaming32 opened this issue Oct 22, 2024 · 2 comments · Fixed by #4180
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.

Comments

@Gaming32
Copy link
Contributor

The dynamic registry loading code calls RegistryKeys.getPath which, unlike getTagsPath, is unpatched by Fabric API. This means that my custom bingo:difficulty dynamic registry gets loaded from data/<namespace>/difficulty instead of the namespaced data/<namespace>/bingo/difficulty.
@modmuss50
Copy link
Member

Is this a new issue in 1.21.2? Or are you seeing this in an older version as well?

@Gaming32
Copy link
Contributor Author

I don't think it's new in 1.21.2, which would technically make fixing this a breaking change.

Gaming32 added a commit to Gaming32/fabric-api that referenced this issue Oct 22, 2024
@Gaming32
Make dynamic registry element path be namespaced
f7d803b 
Fixes FabricMC#4179
@Gaming32 Gaming32 mentioned this issue Oct 22, 2024
Merged
@PepperCode1 PepperCode1 added bug Something isn't working priority:high High priority PRs that need review and work now. Review these first. labels Dec 8, 2024
modmuss50 added a commit that referenced this issue Dec 16, 2024
@Gaming32 @modmuss50
Make dynamic registry element path include namespace for none vanilla…
3f3c499 
… registries (#4180)

* Make dynamic registry element path be namespaced

Fixes #4179

* Remove old method of prepending the namespace

The old method of prepending only applied in certain locations, and thus gives different results depending on the circumstance

* Add simple RegistryKeysTest

---------

Co-authored-by: modmuss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make dynamic registry element path include namespace Gaming32/fabric-api
3 participants
@modmuss50 @Gaming32 @PepperCode1