Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.4] Extra models registered through ModelLoadingPlugin only loading top level #4332

Closed
MrCrayfish opened this issue Dec 28, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@MrCrayfish
Copy link

As of 1.21.4, extra models registered through a ModelLoadingPlugin only load the top model. If the model has a "parent", it is not loaded, resulting in a blank model. This works in Minecraft versions before 1.21.4, but Fabric API has seemed to have lost that behaviour during the update.

@josh321-dev
Copy link

josh321-dev commented Jan 6, 2025

is there a way that they will fix it or is it just how fabric will be now lol

@Linguardium
Copy link

Linguardium commented Jan 6, 2025

This appears to be vanilla behavior in 1.21.4

It will load but not bake parents that are unused otherwise. You can see this by trying to read any of the templated models like cube_all. they are not baked.

@PepperCode1
Copy link
Member

This is a bug. I ported Model Loading API v1 to 1.21.4 but this issue was not brought to my attention; I happened to stumble upon it now. Expect a pull request to fix this soon.

@PepperCode1 PepperCode1 added the bug Something isn't working label Jan 6, 2025
PepperCode1 added a commit to PepperCode1/fabric that referenced this issue Jan 6, 2025
- Adjust testmod to make test extra model have a parent that is not referenced by any other model
@PepperCode1
Copy link
Member

Fixed with Fabric API 0.114.1.

@josh321-dev
Copy link

oh awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants