diff --git a/src/main/java/net/fabricmc/mappingio/FlatMappingVisitor.java b/src/main/java/net/fabricmc/mappingio/FlatMappingVisitor.java index a495f8a0..e7eaef51 100644 --- a/src/main/java/net/fabricmc/mappingio/FlatMappingVisitor.java +++ b/src/main/java/net/fabricmc/mappingio/FlatMappingVisitor.java @@ -62,6 +62,14 @@ default boolean visitContent() throws IOException { return true; } + // TODO: Un-"default" in the next breaking release + default boolean visitPackage(String srcName, @Nullable String[] dstNames) throws IOException { + return false; + } + + // TODO: Un-"default" in the next breaking release + default void visitPackageComment(String srcName, @Nullable String[] dstNames, String comment) throws IOException { } + boolean visitClass(String srcName, @Nullable String[] dstNames) throws IOException; void visitClassComment(String srcName, @Nullable String[] dstNames, String comment) throws IOException; @@ -149,6 +157,17 @@ default boolean visitMethodVar(String srcClsName, String srcMethodName, @Nullabl } // convenience / potentially higher efficiency visit methods for only one dst name + default boolean visitPackage(String srcName, String dstName) throws IOException { + return visitPackage(srcName, toArray(dstName)); + } + + default void visitPackageComment(String srcName, String comment) throws IOException { + visitPackageComment(srcName, (String) null, comment); + } + + default void visitPackageComment(String srcName, @Nullable String dstName, String comment) throws IOException { + visitPackageComment(srcName, toArray(dstName), comment); + } default boolean visitClass(String srcName, String dstName) throws IOException { return visitClass(srcName, toArray(dstName)); diff --git a/src/main/java/net/fabricmc/mappingio/MappedElementKind.java b/src/main/java/net/fabricmc/mappingio/MappedElementKind.java index a046c5f1..6a7c8e8f 100644 --- a/src/main/java/net/fabricmc/mappingio/MappedElementKind.java +++ b/src/main/java/net/fabricmc/mappingio/MappedElementKind.java @@ -20,6 +20,7 @@ * A kind of element that can be mapped. */ public enum MappedElementKind { + PACKAGE(0), CLASS(0), FIELD(1), METHOD(1), diff --git a/src/main/java/net/fabricmc/mappingio/MappingVisitor.java b/src/main/java/net/fabricmc/mappingio/MappingVisitor.java index 7dd01e12..d2920889 100644 --- a/src/main/java/net/fabricmc/mappingio/MappingVisitor.java +++ b/src/main/java/net/fabricmc/mappingio/MappingVisitor.java @@ -28,7 +28,8 @@ *

The visitation order is as follows (omitting visit prefixes for brevity, lowercase for cross-references): *