Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Checksum the exams #79

Merged
merged 6 commits into from
Dec 16, 2021
Merged

WIP: Checksum the exams #79

merged 6 commits into from
Dec 16, 2021

Conversation

christian-heusel
Copy link
Member

@christian-heusel christian-heusel commented Dec 16, 2021 •
edited
Loading

This PR implements functionality so the exams are hashed upon entry to the db so we dont have an append-only DB 😉

Remaining Questions:

  • Should we refactor the hash to be the primary key? ➡️ we could but we dont 😊
  • How do we handle the multiple file reads best? ➡️ io.TeeReader to Buffer & Hash

Fixes #78

@christian-heusel christian-heusel added backend All issues related to the backend feature-request New feature or request question Further information is requested labels Dec 16, 2021
@christian-heusel christian-heusel marked this pull request as draft December 16, 2021 16:24
@christian-heusel christian-heusel marked this pull request as ready for review December 16, 2021 17:36
@christian-heusel christian-heusel merged commit 3e5759e into main Dec 16, 2021
@christian-heusel christian-heusel deleted the 78_checksum_exam branch December 16, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrixapp henrixapp henrixapp approved these changes

Assignees
No one assigned
Labels
backend All issues related to the backend feature-request New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checksum the exams
2 participants
@christian-heusel @henrixapp