Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shorten our localisation namespace names #212

Closed
ahicks92 opened this issue Jul 20, 2024 · 4 comments · May be fixed by #229
Closed

shorten our localisation namespace names #212

ahicks92 opened this issue Jul 20, 2024 · 4 comments · May be fixed by #229
Assignees
Labels
BIG CHANGE Affects multiple files and may prevent parallel work on other things. code cleanup About the code itself rather than its output good first issue Good for new contributors

Comments

@ahicks92
Copy link
Member

Right now it's access.long-name-here. That's easy enough to read with a screen reader (e.g. this isn't a blindness issue). It's very long to write all the time. As we move away from English strings, we're going to have it freaking everywhere. While we still can, let's switch to a shorter name. I like fa as we already use it pretty universally both in code and conversation.

This isn't the end of the world or anything but right now we're so bad at localisatino that it's easy to change our mind, so lets.

@ahicks92 ahicks92 added good first issue Good for new contributors BIG CHANGE Affects multiple files and may prevent parallel work on other things. code cleanup About the code itself rather than its output labels Jul 20, 2024
@ahicks92 ahicks92 self-assigned this Jul 20, 2024
@ahicks92
Copy link
Member Author

Took it myself. It's a find/replace. Should take 10 minutes. Maybe tomorrow. Too tired and frustrated at stupid things to code right now.

Technically "big change". Not really though. I doubt I am going to wake up tomorrow to find out someone needed 100 strings or something all of a sudden.

@LevFendi
Copy link
Member

The "access" into "fa" part sounds good to me, go ahead. I do not understand the rest: What are you proposing about the long key names? They need to be long so that they precisely explain what they are both for the coder and the translator to understand.

@ahicks92
Copy link
Member Author

access adds a long thing to a long thing. long-name-here is just a placeholder because I am lazy and didn't feel like digging up a real example. I'm not going to be changing key names nor proposing that we should adopt a different style there.

@LevFendi
Copy link
Member

Okay yes please go ahead with this

ahicks92 added a commit that referenced this issue Aug 12, 2024
ahicks92 added a commit that referenced this issue Aug 19, 2024
ahicks92 added a commit that referenced this issue Aug 22, 2024
ahicks92 added a commit that referenced this issue Aug 26, 2024
ahicks92 added a commit that referenced this issue Sep 6, 2024
ahicks92 added a commit that referenced this issue Sep 12, 2024
ahicks92 added a commit that referenced this issue Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BIG CHANGE Affects multiple files and may prevent parallel work on other things. code cleanup About the code itself rather than its output good first issue Good for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants