Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Available Icon #2059

Open
McCoyCOREUSA opened this issue Nov 21, 2024 · 7 comments
Open

Update Available Icon #2059

McCoyCOREUSA opened this issue Nov 21, 2024 · 7 comments
Assignees

Comments

@McCoyCOREUSA
Copy link

It would be helpful if in the upper-left corner where the version is shown, to have an icon or the text "Update Available" if an update is available.

It might be good to have it specify if it's a branch update or a major OS update.

@AGFazio
Copy link

AGFazio commented Nov 25, 2024

I'll second that. It would be great addition.

@patdelaney
Copy link
Contributor

I believe we used to have an alert in very early versions of FPP. I don't remember the exact reason we removed it, but the following issues come to mind.

  • for people that don't want to update, the alert was always there.
  • formatting mobile devices

If you go to help->About all the information about any updated is there.

@dkulp
Copy link
Contributor

dkulp commented Nov 25, 2024

The main issue is performance. Checking GitHub for updates is expensive. When you go to the about page, we can trigger it once, but it's certainly not something to run every time the status page is loaded (or worse; on refresh).

I'm wondering if we could add a GitHub action or something that would record the latest git hash for each of the main branches into a json file and auto publish that someplace that the browser could retrieve. Wouldn't have any impact on the FPP device, just the browser. Hmmm.. @computergeek1507 - you are way more familiar with GH actions than I am, do you know if something like that may be doable relatively easily?

@McCoyCOREUSA
Copy link
Author

Even if it could check once on start of FPP. Then once there is an update available, store it locally and display an upgrade available icon. Then, until an update is performed, there is no need to check again. Further, the check can be limited to once per day. There is no need to check Github every load or whatever. Just once a day until an update is available, then it doesn't check again until updated.

@ghormann
Copy link
Member

@dkulp I've done something in the past where we had on Github repo generate a file and check it into another with each commit. Could do this against https://github.com/FalconChristmas/FalconChristmas.github.io Would need an API token that could commit to the other repo.

The other option is a cron action that runs daily and if there are any changes, updates the main repo.

@darylc
Copy link
Contributor

darylc commented Feb 1, 2025

The FPP developers discussed this, is not clear it is practical to do this, thats why it was initially removed - but Greg has volunteered to investigate options for a scalable solution.

@ghormann
Copy link
Member

ghormann commented Feb 9, 2025

I'm keeping this open WHile upgrading on the same branch work, and it detects newer branches, it needs to change the target URL when doing a branch upgrade to something like ViewReleaseNotes('7.5');"

@ghormann ghormann reopened this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

6 participants