Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to include source DATA in the object model #19

Open
michelesalvador opened this issue Sep 28, 2020 · 1 comment
Open

How to include source DATA in the object model #19

michelesalvador opened this issue Sep 28, 2020 · 1 comment

Comments

@michelesalvador
Copy link
Contributor

According to the GEDCOM 5.5.1 standard a source can have a subordinate DATA tag storing additional informations:

n @<XREF:SOUR>@ SOUR			{1:1}
+1 DATA					{0:1}
+2 EVEN <EVENTS_RECORDED>		{0:M}
+3 DATE <DATE_PERIOD>			{0:1}
+3 PLAC <SOURCE_JURISDICTION_PLACE>	{0:1}
+2 AGNC <RESPONSIBLE_AGENCY>		{0:1}
+2 <<NOTE_STRUCTURE>>			{0:M}
...

At the moment this DATA tag and its subordinates are not included in the object model.
I'd like to submit a pull request to fix.

I have created a SourceData class and a DataEvent class.
But now I have a doubt: in SourceData is it better to define a single DataEvent or a List<DataEvent>?

In the real world of GEDCOMs is there usually only one EVEN under DATA?
Or is it actually common to have multiple EVEN, in accordance to the standard?

@michelesalvador
Copy link
Contributor Author

Receiving no response I will opt for what I think is best.
I will follow the GEDCOM 5.5.1 standard, that is the possibility to add multiple EVEN under DATA.

michelesalvador added a commit to michelesalvador/gedcom5-java that referenced this issue Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant