Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of EventFact display types #20

Open
michelesalvador opened this issue Sep 29, 2020 · 1 comment
Open

Translation of EventFact display types #20

michelesalvador opened this issue Sep 29, 2020 · 1 comment

Comments

@michelesalvador
Copy link
Contributor

I'm developing the Family Gem app, that is strongly based on this amazing Gedcom parser.
Family Gem at the moment is translated in 10 languages and growing.

Obviously a core feature of Family Gem is to add events and facts to persons and families.
The "display type" of each event/fact is taken from EventFact.java (e.g. "Birth" is the display type for BIRT).
These display types are hard-coded in English, and unfortunately no translation system is provided by the Gedcom parser.

Of course inside Family Gem I could filter the English display type and replace it with a translation..
But wouldn't it be great if a translation of display types was provided inside Gedcom, available for all the users of the library?

@stoicflame
Copy link
Member

Hi.

Sure, thanks for your work. Do you want to put together a pull request that captures how you propose the code manages those display types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants