Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Command Line IP and MTU Address Change #29

Closed
kb1lqc opened this issue Mar 7, 2018 · 2 comments
Closed

Provide Command Line IP and MTU Address Change #29

kb1lqc opened this issue Mar 7, 2018 · 2 comments
Assignees
@kb1lqc
Labels
enhancement New feature or request

Comments

@kb1lqc
Copy link
Member

kb1lqc commented Mar 7, 2018

I realized one cannot change the IP address from the command line. This makes setting up a network difficult!
@kb1lqc kb1lqc added the enhancement New feature or request label Mar 7, 2018
@kb1lqc kb1lqc self-assigned this Mar 7, 2018
@kb1lqc kb1lqc changed the title Provide Command Line IP Address Change Provide Command Line IP and MTU Address Change Mar 9, 2018
kb1lqc added a commit to kb1lqc/faradayio-cli that referenced this issue Mar 9, 2018
@kb1lqc
Per FaradayRF#29 added a -m and -mtu option to set MTU size
b104ec6
kb1lqc added a commit to kb1lqc/faradayio-cli that referenced this issue Mar 9, 2018
@kb1lqc
Added ip address -i' and --addr` option per FaradayRF#29
bc80c7b
kb1lqc added a commit to kb1lqc/faradayio-cli that referenced this issue Mar 9, 2018
@kb1lqc
Added IP and MTU options to Monitor() implementation per FaradayRF#29
ec46aae 
* Added the command line arguments to the Monitor() instance
@kb1lqc
Copy link
Member Author

kb1lqc commented Mar 9, 2018

I added initial code implementations to https://github.com/kb1lqc/faradayio-cli/tree/issue29 which satisfies the basic requirement of this IT.

However, I should consider

  • Checking user input for validity
  • Unit testing user input

This was referenced Mar 11, 2018
Open
Merged
@kb1lqc
Copy link
Member Author

kb1lqc commented Mar 11, 2018

Closing as items addressed and merged into develop while any additional work is to be captured on #30 for user validation.

@kb1lqc kb1lqc closed this as completed Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kb1lqc kb1lqc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kb1lqc