Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Why was FuncEnv.state_info() renamed to FuncEnv.initial_info()? #855

Closed
Kallinteris-Andreas opened this issue Dec 22, 2023 · 1 comment · Fixed by #862
Closed
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@Kallinteris-Andreas
Copy link
Collaborator

Question

In #818 state_info was renamed to initial_info with no explanation, what was the reason?

I suggest that this change be reversed, as you have state info in each step for some environments.

@RedTachyon
Thanks

@Kallinteris-Andreas Kallinteris-Andreas added the question Further information is requested label Dec 22, 2023
@RedTachyon
Copy link
Member

It was renamed at some point in the past due to a misunderstanding about this function's intention, it should definitely be state_info. To make things more fun, the current code has a messed up transform with self.state_info = func(self.initial_info) due to this.

So this needs to be fixed, changing it consistently to state_info. If you or someone else can do it, that'd be great, otherwise I'll do it at some point soon-ish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants