Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix render arguments #518

Closed
wants to merge 10 commits into from

Conversation

zhaoyi11
Copy link

@zhaoyi11 zhaoyi11 commented Dec 16, 2024

Fix render arguments when using single tasks

The current implementation has an issue in that it only allows changing render_mode during rendering

def initialize(env, seed=None, render_mode=None):
. However, in many cases, we need to change rendered image size as well as camera view. I replace render_mode with **render_kwargs such that users can set width height and camera_name when initializing the environment.

Modifications

Additional dependencies

None

TODO:

Currently, for camera corner, corner2 and corner3, the rendered images incorrectly rotate 90 degrees. It might be because of using OpenGL vs. opencv as the rendering backbone. image[::-1] can correct the images when using these camera views.

@reginald-mclean
Copy link
Collaborator

Thank you for the PR, we are currently working on an updated version of Meta-World that will fix these issues but has a different codebase structure so this PR isn't needed from our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants