Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Any plan to support BabyAI bot ? #308

Closed
GilgameshD opened this issue Feb 17, 2023 · 6 comments · Fixed by #381
Closed

[Question] Any plan to support BabyAI bot ? #308

GilgameshD opened this issue Feb 17, 2023 · 6 comments · Fixed by #381

Comments

@GilgameshD
Copy link
Contributor

Question

Thanks for bringing BabyAI into this repo. I wonder if there is any plan to support the bot that can generate expert demonstrations (link of the script).

@pseudo-rnd-thoughts
Copy link
Member

I haven't done much with BabyAI but I would add happy to add it if it is helpful to end users. @rodrigodelazcano Any thoughts?
@GilgameshD Would you be interested in adding the file in a PR? It would need to include a copyright statement at the top of the file

@rodrigodelazcano
Copy link
Member

I think this could be very valuable in order to generate datasets for Minari.
I currently don't have time to work on it but if @GilgameshD you want to contribute to this I'll be happy to help with code review :)

@GilgameshD
Copy link
Contributor Author

sounds good. I will try to make a PR when I finish it.

@Near32
Copy link

Near32 commented Mar 14, 2023

Hello!
I have updated the BabyAI bot to be operatable with both the legacy code and the Minigrid code, in case it can speed up full integration in here :
mila-iqia/babyai#121
Good luck in the meantime!

@GilgameshD
Copy link
Contributor Author

thanks @Near32 for providing a reference of the modification. I made the bot.py file compatible with Minigrid and wrote a simple example to run the bot on all BabyAI envs. Where do you think I should put the files? @pseudo-rnd-thoughts @rodrigodelazcano

@pseudo-rnd-thoughts
Copy link
Member

@GilgameshD Would you be able to put it in minigrid/utils/bot.py along with several tests in tests/utils/test_bot.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants