Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Options for Slicing Passengers DF rather than Copy #133

Open
danielsclint opened this issue Mar 9, 2018 · 1 comment
Open

Provide Options for Slicing Passengers DF rather than Copy #133

danielsclint opened this issue Mar 9, 2018 · 1 comment
Labels
memory

Comments

@danielsclint
Copy link

The following code creates a copy of a slice of the pathset_link_df or pathset_path_df when a copy is not always necessary. Change method signature to allow the slice to be returned instead of copy.

https://github.com/BayAreaMetro/fast-trips/blob/701134f0d55fc983f76bef24031b99b3cb199350/fasttrips/Passenger.py#L1033-L1045
danielsclint pushed a commit to danielsclint/fast-trips that referenced this issue Mar 9, 2018
Provide slice option for passengers. (Fast-Trips#133)
25f0e56
@e-lo
Copy link
Member

e-lo commented Mar 27, 2018

@danielsclint - feel free to submit a PR or commit directly to dev branch [with passing tests] with this type of fix

danielsclint pushed a commit to danielsclint/fast-trips that referenced this issue Jun 29, 2018
Provide slice option for passengers. (Fast-Trips#133)
81f3978
e-lo pushed a commit that referenced this issue Jul 2, 2018
@e-lo
Provide slice option for passengers. (#133)
35ec12b
e-lo pushed a commit that referenced this issue Jul 2, 2018
@e-lo
Provide slice option for passengers. (#133)
4f72284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
memory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@e-lo @danielsclint