Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove final on inherited methods in BuilderBasedDeserializer to allow overriding by subclasses. #1870

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Remove final on inherited methods in BuilderBasedDeserializer to allow overriding by subclasses. #1870

merged 1 commit into from
Jan 4, 2018

Conversation

vjkoskela
Copy link
Contributor

As discussed in #1869.

@vjkoskela vjkoskela mentioned this pull request Dec 24, 2017
Closed
@cowtowncoder cowtowncoder merged commit d2eeef7 into FasterXML:master Jan 4, 2018
@cowtowncoder
Copy link
Member

Oh. Just realized one thing: this for master, and not 2.9. I am guessing you would want this 2.9(.4) too?

@cowtowncoder cowtowncoder changed the title Remove final on inherited methods in BuilderBasedDeserializer to allow overriding by subclasses. Remove final on inherited methods in BuilderBasedDeserializer to allow overriding by subclasses. Jan 4, 2018
@cowtowncoder cowtowncoder added this to the 2.9.4 milestone Jan 4, 2018
@cowtowncoder
Copy link
Member

Backported this in 2.9, will be in 2.9.4.

@vjkoskela
Copy link
Contributor Author

Thanks you!

@vjkoskela vjkoskela deleted the remove-final-BuilderBasedDeserializer branch October 3, 2019 18:07
@vjkoskela vjkoskela mentioned this pull request Oct 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.4
Development

Successfully merging this pull request may close these issues.
2 participants
@vjkoskela @cowtowncoder