Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashCode implementations where there are none #940

Merged
merged 1 commit into from
Sep 24, 2015

Conversation

Sergio-Mira
Copy link

Fixes issues when using .hashCode for any node that contains either Boolean, Null, etc values

@cowtowncoder
Copy link
Member

Makes sense, thank you for contribution.
I will be happy to merge it.

There is one practicality first, since this is your first contribution (I think?) to Jackson projects.
We need a Contributor License Agreement (CLA), from: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf
and once receiving it, can accept any and all contributions.

The common way to do this is to print CLA, fill & sign, scan and email to info at fasterxml dot com.
As soon as we receive it, I'll merge the patch.

Thank you again.

@Sergio-Mira
Copy link
Author

I've sent the CLA, let me know if it looks good. Cheer!

cowtowncoder added a commit that referenced this pull request Sep 24, 2015
Add hashCode implementations where there are none
@cowtowncoder cowtowncoder merged commit 313a713 into FasterXML:master Sep 24, 2015
@cowtowncoder
Copy link
Member

Merged, backported in 2.6 for 2.6.3 as well.

Thank you again for this contribution -- it was an odd oversight that these were missing!

@Sergio-Mira
Copy link
Author

Thanks for applying it so quickly! If we use 2.6.3 form maven the patch will be there? 💃

@cowtowncoder
Copy link
Member

@Sergio-Mira yes, once we release 2.6.3 this will be part of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants