Skip to content
This repository has been archived by the owner on Jan 22, 2019. It is now read-only.

support serialization of BigDecimal values #27

Merged
merged 1 commit into from
Nov 25, 2015
Merged

Conversation

osi
Copy link

@osi osi commented Nov 24, 2015

Avro doesn't have direct support for BigDecimal. Since jackson's schema generation considers them a double, translate values to a double prior to serialization.

Deserialization does not currently work since jackson wants to read the value as a string and use the BigDecimal(String) constructor.

@cowtowncoder
Copy link
Member

Sounds and looks good. Happy to merge.

One question before I merge this: have I already asked for and gotten the CLA? If not, it's available from

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and we need to get it filled once, just to ensure we can distribute code that includes contributions. Or, rather, soothes corporate users who are worried about provenance of code within OSS projects (personally I would assume contributor does indeed mean to contribute code and knows ramifications but try explaining that a legal professional :) ).
The simplest way to do this is usually to d/l and print document, fill, scan and email to info at fasterxml dot com. We'll file it in a private place, and off I go merging reviewed contributions.

Apologies if you already sent one; we get quite a few of these.

@osi
Copy link
Author

osi commented Nov 24, 2015

no problem. i just sent one off.

@cowtowncoder
Copy link
Member

Awesome thanks.

cowtowncoder added a commit that referenced this pull request Nov 25, 2015
support serialization of BigDecimal values
@cowtowncoder cowtowncoder merged commit aceb22e into FasterXML:2.6 Nov 25, 2015
@cowtowncoder cowtowncoder modified the milestones: 2.4.0, 2.6.4 Nov 25, 2015
cowtowncoder added a commit that referenced this pull request Nov 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants