[Avro] Fix MapWriteContext not correctly resolving union values #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently discovered a bug with the Avro serializer where using a map whose values are a union of multiple record schemas fails because the
MapWriteContext
does not pass each item tocreateChildObjectContext()
, so Jackson can't resolve which schema in the union should be used.I've added a test that demonstrates the issue and the associated fix in
MapWriteContext
.It looks like this issue was fixed upstream as a part of the refactoring in 8b9171c for 3.0, but we'd like to utilize this in 2.9.