Allow use of LoaderOptions.allowDuplicateKeys to enforce duplicate key detection
#415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
approved these changes
Apr 13, 2023
|
Looks good. Just one piece of paperwork: if you haven't yet sent CLA (just needs to be done once, ever), we'd need this: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf (and usually it's easiest to print, fill & sign, scan/photo, email to and once we have it, can proceed merging the PR. Thank you for the PR; I think this is a nice ergonomic improvement! |
cowtowncoder
added
the
cla-needed
|
@cowtowncoder I have sent the signed CLA just now. |
cowtowncoder
removed
the
cla-needed
|
CLA received. |
cowtowncoder
changed the title
LoaderOptions.allowDuplicateKeys to enforce duplicate key detection
cowtowncoder
added a commit
that referenced
this pull request
Apr 14, 2023
cowtowncoder
changed the title
LoaderOptions.allowDuplicateKeys to enforce duplicate key detectionLoaderOptions.allowDuplicateKeys to enforce duplicate key detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user sets the allowDuplicateKeys to false in the LoaderOptions they expect the system will fail on a duplicate key.
It does not (see #413 ) and no errors are given to indicate they should have set it in a different way.
With this simple change it will fail on duplicate keys.