Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jackson doesn't see companion object @JsonCreators unles they also have @JvmStatic #355

Open
dinomite opened this issue Jul 31, 2020 · 3 comments
Labels

Comments

@dinomite
Copy link
Member

Describe the bug
Jackson doesn't see builder methods in a companion object unless they are annotate with @JvmStatic.

To Reproduce
PR with repro test #354

Expected behavior
Jackson should find @JsonCreator-annotated methods on companion objects.

Versions
Kotlin:
Jackson-module-kotlin: 2.11.2
Jackson-databind: 2.11.2

@dinomite dinomite added the bug label Jul 31, 2020
@dinomite
Copy link
Member Author

dinomite commented Sep 3, 2020

I was caught by this the other day, filed this, and made a repro branch, but now I'm reading the caveats section of the README and it's listed right there. Keeping those around because maybe I'll look into this, but I'm guessing since it's a listed caveat there isn't an easy solution.

@cowtowncoder
Copy link
Member

@dinomite looks like src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/failing/Github335.kt is "failing to fail" (I think?) on 2.12... was mentioned in context of #182 / #419.

@dinomite
Copy link
Member Author

Looks like it was actually issue #335 that was fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants