You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* This feature represents whether to check deserialized collections.
*
* With this disabled, the default, collections which are typed to disallow null members (e.g. `List<String>`)
* may contain null values after deserialization.
* Enabling it protects against this but has significant performance impact.
*/
StrictNullChecks(enabledByDefault =false);
Are there any benchmarks to check the performance against the enabled and disabled feature? If not, would you like me to contribute the microbenchmark suite by creating a dedicated pull request?
I found that @k163377 used jmh to give you some numbers to prove significant improvement in deserialization speed #439 but those tests are not part of the jackson-module-kotlin project.
The text was updated successfully, but these errors were encountered:
We can see a clear performance degradation even with only one argument deserialization.
Also, since the StrictNullChecks option checks all arguments regardless of type, if there is more arguments, the bigger the performance loss.
It may be too late to confirm the impact on overall performance, but we have done so and will share it with you.
As a conclusion, the performance impact to anything other than Collection deserialization did not seem to be that significant. https://github.com/ProjectMapK/kogera-benchmark#comparison-of-strictnullchecks
I am considering enabling the
StrictNullChecks
feature in production. However, In the Javadoc I can see following statement:jackson-module-kotlin/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinFeature.kt
Lines 38 to 45 in 11bfe2f
Are there any benchmarks to check the performance against the enabled and disabled feature? If not, would you like me to contribute the microbenchmark suite by creating a dedicated pull request?
I found that @k163377 used jmh to give you some numbers to prove significant improvement in deserialization speed #439 but those tests are not part of the jackson-module-kotlin project.
The text was updated successfully, but these errors were encountered: