Serializer for Scala Map converts to Java Map - avoid this conversion #470
Comments
|
This task will probably require copying https://github.com/FasterXML/jackson-databind/blob/166ce08b96465fc2a2a9ae385919c38ac3a3b6b4/src/main/java/com/fasterxml/jackson/databind/ser/std/MapSerializer.java (all 1000+ lines) and writing a version that handles Scala Maps natively (ie without converting the Scala map to a Java Map). After getting that working, we would need a big new suite of tests that test serializing maps with a large variety of ObjectMapper configs. We get away (to an extent) without having a big barrage of Map serializaton tests because we reuse the Java support (at the moment). My advice to anyone is to avoid using Maps. They put too complexity on the JSON serialization framework. Use Collections of strongly typed data. |
retronym
added a commit
to retronym/jackson-module-scala
that referenced
this issue
Dec 4, 2023
…g is enabled. This Map serializer is implemented in terms of the Java version and is somewhat fragile, as discussed in FasterXML#643 / FasterXML#470. This commit ensures that the wrapper class is a member class in both Scala and Java. That results in this JSON as the serializer code chooses not to put the inner class name in the type annotation. ``` {"m":["scala.collection.immutable.Map",{"one":"one","two":"two"}]} ``` Fixes FasterXML#643
retronym
added a commit
to retronym/jackson-module-scala
that referenced
this issue
Dec 4, 2023
…g is enabled. This Map serializer is implemented in terms of the Java version and is somewhat fragile, as discussed in FasterXML#643 / FasterXML#470. This commit ensures that the wrapper class is a member class in both Scala and Java. That results in this JSON as the serializer code chooses not to put the inner class name in the type annotation. ``` {"m":["scala.collection.immutable.Map",{"one":"one","two":"two"}]} ``` Fixes FasterXML#643
retronym
added a commit
to retronym/jackson-module-scala
that referenced
this issue
Dec 4, 2023
…g is enabled. This Map serializer is implemented in terms of the Java version and is somewhat fragile, as discussed in FasterXML#643 / FasterXML#470. This commit ensures that the wrapper class is a member class in both Scala and Java. That results in this JSON as the serializer code chooses not to put the inner class name in the type annotation. ``` {"m":["scala.collection.immutable.Map",{"one":"one","two":"two"}]} ``` Fixes FasterXML#643
retronym
added a commit
to retronym/jackson-module-scala
that referenced
this issue
Dec 4, 2023
This Map serializer is implemented in terms of the Java version and is somewhat fragile, as discussed in FasterXML#643 / FasterXML#470. This commit ensures that the wrapper class is a member class in both Scala and Java. That results in this JSON as the serializer code chooses not to put the inner class name in the type annotation. ``` {"m":["scala.collection.immutable.Map",{"one":"one","two":"two"}]} ``` Fixes FasterXML#643
retronym
added a commit
to retronym/jackson-module-scala
that referenced
this issue
Dec 4, 2023
This Map serializer is implemented in terms of the Java version and is somewhat fragile, as discussed in FasterXML#643 / FasterXML#470. This commit ensures that the wrapper class is a member class in both Scala and Java. That results in this JSON as the serializer code chooses not to put the inner class name in the type annotation. ``` {"m":["scala.collection.immutable.Map",{"one":"one","two":"two"}]} ``` Fixes FasterXML#643
retronym
added a commit
to retronym/jackson-module-scala
that referenced
this issue
Dec 4, 2023
This Map serializer is implemented in terms of the Java version and is somewhat fragile, as discussed in FasterXML#643 / FasterXML#470. This commit ensures that the wrapper class is a member class in both Scala and Java. That results in this JSON as the serializer code chooses not to put the inner class name in the type annotation. ``` {"m":["scala.collection.immutable.Map",{"one":"one","two":"two"}]} ``` Fixes FasterXML#643
pjfanning
pushed a commit
that referenced
this issue
Dec 4, 2023
This Map serializer is implemented in terms of the Java version and is somewhat fragile, as discussed in #643 / #470. This commit ensures that the wrapper class is a member class in both Scala and Java. That results in this JSON as the serializer code chooses not to put the inner class name in the type annotation. ``` {"m":["scala.collection.immutable.Map",{"one":"one","two":"two"}]} ``` Fixes #643
pjfanning
pushed a commit
that referenced
this issue
Dec 4, 2023
This Map serializer is implemented in terms of the Java version and is somewhat fragile, as discussed in #643 / #470. This commit ensures that the wrapper class is a member class in both Scala and Java. That results in this JSON as the serializer code chooses not to put the inner class name in the type annotation. ``` {"m":["scala.collection.immutable.Map",{"one":"one","two":"two"}]} ``` Fixes #643
|
I'll close this for now. I suspect that the (probably small) potential perf gains are more than offset by the cost of maintaining a large custom Scala Map serializer. The Java Map serializer is pretty complicated (in jackson-databind). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: